Add server name validation to MCP config loader #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to ensure server names in MCP configuration files contain only alphanumeric characters and hyphens. The validation prevents invalid configurations from being loaded by raising a ValueError early in the process.
Key changes:
- Added server name validation using regex pattern matching
- Modified configuration loading to validate each server name before creating McpServer instances
- Introduced early error handling for invalid server names
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The _servers attribute is not initialized before being used. |
Karanraj-6
commented
Sep 17, 2025
|
Hi @Karanraj-6 thanks for your contribution. Can you please rebase and squash the commits? |
- Validate server names contain only letters, numbers, and hyphens - Raise ValueError for invalid server names - Initialize self._servers before populating
Karanraj-6
force-pushed
the
add-server-name-validation
branch
from
21d2c8e to
e4a3863
Compare
|
@cristipufu I’ve rebased and squashed the commits. Can you please review and merge when you get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
Validate that server names contain only letters, numbers, and hyphens.
Raise a ValueError if an invalid server name is found, preventing the loading of invalid configurations early.
Update _load_config in McpConfig to incorporate the validation step.
Motivation:
Ensures that only properly formatted server names are loaded, reducing potential runtime errors and improving reliability of MCP configuration handling.
Testing:
Initialized McpConfig locally.
Printed all server names to confirm validation runs without errors.
Verified that invalid server names correctly raise ValueError.