Add Blocks machines to ultimaker cura by jgrilo-blocks · Pull Request #11620 · Ultimaker/Cura

jgrilo-blocks · 2022-03-07T11:34:12Z

First definitions of Blocks machines for Ultimaker Cura

Definition files to add Blocks printers

Extruder files for Blocks printers

Mesh files for Blocks printers

Quality setting files for Blocks printers for nozzle and print core variants

Variants files for Blocks printers that include nozzle and print core variants

Ghostkeeper · 2022-03-16T16:03:13Z

Belongs to Ultimaker/fdm_materials#195. They should be merged at the same time.

The tests are currently failing. It fails for a lot of files, but it seems that at least for some of them it's because the SettingVersion is outdated (should be 19 instead of 17). That indicates that you might have tested this in Cura 4.13 instead of in Cura 5.0. Do they work with Arachne?

jgrilo-blocks · 2022-03-16T16:45:07Z

Thanks for the feedback @Ghostkeeper, yes we tested them on Cura 4.13 but they work in Arachne, we will fix the SettingVersion of the files.
Should we do a new pull request after that?

Ghostkeeper · 2022-03-23T09:44:32Z

You can just update the master branch of BlocksTechnology's fork with new commits. Github will automatically update this Pull Request with your latest changes. That's also the easiest for us.

Variants files for Blocks printers that include nozzle and print core variants

This reverts commit 6d7617b.

Variants files for Blocks printers that include nozzle and print core variants SettingVersion updated to work with Cura 5.0

Quality setting files for Blocks printers for nozzle and print core variants SettingVerison updated to work with Cura 5.0

Edited start Gcode of Blocks Zero and Blocks R21

Updated Start GCODE

braga-dev · 2022-06-22T13:13:01Z

@Ghostkeeper any updates when this branch will be merged?

nallath

Apologies for the slow review! I'm trying to get through all the open PR's again.

I've not checked all the settings, but I've found quite a few settings that re-define defaults. This makes it a lot harder to maintain the profile, so it's generally best to adhere to the DRY (Don't repeat yourself) as much as possible.

Furthermore, we also require buildplate meshes to be well below 1mb. Try to exclude any unneeded details like springs / screws.

nallath · 2022-09-15T12:09:49Z

resources/quality/blocks/Nozzle/blocks_global_0.20_standard.inst.cfg

+[values]
+layer_height = 0.1
+layer_height_0 = 0.15
+material_diameter = 1.75


This should not be set in a quality profile. It's already being set by the extruder. THese can (and should) be removed from all of them.

nallath · 2022-09-15T12:10:31Z

resources/quality/blocks/Nozzle/blocks_global_0.20_standard.inst.cfg

+definition = blocks_base
+
+[metadata]
+setting_version = 19


setting version is 20 now (not a big deal if you don't fix it, but it will make the tests fail right now)

resources/definitions/blocks_pros30.def.json

nallath · 2022-09-15T12:12:26Z

resources/definitions/blocks_base.def.json

+    "travel_avoid_supports": { "value": true },
+    "travel_retract_before_outer_wall": { "value": true },
+
+    "retraction_enable": { "value": true },


Suggested change

"retraction_enable": { "value": true },

This is already the default in fdmprinter, no need to repeat yourself.

nallath · 2022-09-15T12:13:33Z

resources/definitions/blocks_base.def.json

+
+    "retraction_speed": {
+      "deafult_value": 40,
+      "maximum_value_warning": "machine_max_feedrate_e if retraction_enable else float('inf')",


Suggested change

"maximum_value_warning": "machine_max_feedrate_e if retraction_enable else float('inf')",

Already the default, no need to repeat yourself

nallath · 2022-09-15T12:16:49Z

resources/definitions/blocks_base.def.json

+    "speed_wall": { "value": "speed_print / 2" },
+    "speed_wall_0": { "value": "speed_wall" },


Suggested change

"speed_wall": { "value": "speed_print / 2" },

"speed_wall_0": { "value": "speed_wall" },

nallath · 2022-09-15T12:17:26Z

resources/definitions/blocks_base.def.json

+    "speed_topbottom": { "value": "speed_print / 2" },
+    "speed_roofing": { "value": "speed_topbottom" },


Suggested change

"speed_topbottom": { "value": "speed_print / 2" },

"speed_roofing": { "value": "speed_topbottom" },

nallath · 2022-09-15T12:18:19Z

resources/definitions/blocks_base.def.json

+    "line_width": { "value": "machine_nozzle_size" },
+    "wall_line_width": { "value": "machine_nozzle_size" },


Suggested change

"line_width": { "value": "machine_nozzle_size" },

"wall_line_width": { "value": "machine_nozzle_size" },

nallath · 2022-09-15T12:19:31Z

resources/definitions/blocks_pros30.def.json

+    "machine_height": { "default_value": 290 },
+    "machine_depth": { "default_value": 310 },
+
+    "retraction_retract_speed": { "value": 40, "maximum_value_warning": 130 },


Why not just define the maximum value_warning in the base file? THey seem to be the same for all machines.

nallath · 2022-09-15T12:19:56Z

resources/definitions/blocks_pros30.def.json

+
+    "retraction_retract_speed": { "value": 40, "maximum_value_warning": 130 },
+    "retraction_prime_speed": { "value": 20, "maximum_value_warning": 130 },
+    "speed_print": { "value": 50 },


It's the same for all printers. So why not just put it in the base file?

Co-authored-by: Jaime van Kessel <nallath@gmail.com>

braga-dev · 2022-10-14T16:44:01Z

@nallath changes were made and machines added. Thank you so much for the help

braga-dev · 2022-11-05T15:30:17Z

@nallath any chance to review the printer and quality profiles? thank you

jellespijker · 2022-11-29T19:18:45Z

Can you sync your fork, with our main. We have added a printer-linter tool for our printer definitions and profiles. This should help us with processing our PR's. It performs some standard diagnostic checks and apply auto-formatting on the changed files in this PR, but you can also run it locally. See https://github.com/Ultimaker/Cura/tree/main/printer-linter

If it finds issues for which it knows a fix it should post a comment with that suggested fix such that you can easily commit that fix if you're okay with it.
But please use commonsense with the suggestions because the tool is still in the early stages of development.

braga-dev · 2022-12-19T21:52:58Z

@jellespijker how are you? is it possible to approve the workflow to check if there is more diagnostics with printer-liner? thank you

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

resources/definitions/blocks_base.def.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

braga-dev · 2022-12-30T11:21:39Z

@jellespijker just updated with the last commits! Let's hope its the final one :D

Improves readability

Contributes to CURA-10101

The settings: - travel_compensate_overlapping_walls_0_enabled - fill_perimeter_gaps - filter_out_tiny_gaps Are no longer used with the new Arachne engine. That these settings were still set in the blocks_base definition is an indication that the current profiles weren't actually tested with the new Arachne engine. Please consider doing some actual quality tests with these profiles on your printers. This is for the benefit of your users experience. Contributes to CURA-10101

Contributes to CURA-10101

jellespijker

Still multiple issues and failing Unit Tests so I can't press merge :-(

To help you guys out a bit I made a PR against your fork. See BlocksTechnology#1

If you agree with these suggested changes feel free to merge it on your fork, this should also update this PR.

I will convert this PR to a WIP PR. You can convert it back once it is ready to be reviewed again.

jellespijker · 2023-01-06T09:28:15Z

@braga-dev and @jgrilo-blocks Do you guys need additional help with this PR? Or is merging my PR on your fork enough? BlocksTechnology#1

It would be nice if we can add your printers in Cura 5.3.0

Blockstech

braga-dev · 2023-01-06T18:30:54Z

hello @jellespijker sorry for the delay. We just fixed the last issue so its all probably fine. We already tested these print profiles in Cura 5 and they are working fine so there won't be a problem.

For future updates, its going to be easier/faster than the first ones right?

jellespijker · 2023-01-06T18:41:41Z

Don't worry. The main delay was originally on our side. We are finally catching up.

Yes, updates and new printers should now be processed way faster due to our improved workflow.

I will take a look at the fixes first thing o Monday. Good to hear that they have been tested on Cura 5.x.

If all goes well, these printers should be available in Cura 5.3

jellespijker · 2023-01-06T18:43:09Z

just mark it ready for review when you're finished so we know that we can review it.

braga-dev · 2023-01-06T18:51:38Z

Hello @jellespijker perfect. Great to hear that. I don't have write access so I can't make it ready for review.

jellespijker

LGTM;

Two minor fixes which I will quickly fix myself when I merge it.
Congrats guys, your printers should be available in Cura 5.3

jellespijker · 2023-01-10T07:23:11Z

resources/definitions/blocks_base.def.json

+        "retraction_hop_enabled": { "value": "False" },
+        "retraction_prime_speed":
+        {
+            "deafult_value": 20,


Suggested change

"deafult_value": 20,

"default_value": 20,

I will change these myself after I merge them

jellespijker · 2023-01-10T07:23:34Z

resources/definitions/blocks_base.def.json

+        },
+        "retraction_speed":
+        {
+            "deafult_value": 40,


Suggested change

"deafult_value": 40,

"default_value": 40,

I will change these myself after I merge them

Applied changes where necesarry

braga-dev · 2023-01-13T09:51:38Z

Hello @jellespijker ! Thank you very much! Can't wait.

jgrilo-blocks added 5 commits March 7, 2022 11:06

add definition files Blocks

58505d9

Definition files to add Blocks printers

add extruder files

6a8e695

Extruder files for Blocks printers

Add mesh files

15ab283

Mesh files for Blocks printers

add quality setting files

8caacfa

Quality setting files for Blocks printers for nozzle and print core variants

add variants files

17d93d0

Variants files for Blocks printers that include nozzle and print core variants

Ghostkeeper mentioned this pull request Mar 16, 2022

Edited generic material files Ultimaker/fdm_materials#195

Open

jgrilo-blocks and others added 6 commits March 23, 2022 10:26

add variants files

6d7617b

Variants files for Blocks printers that include nozzle and print core variants

Revert "add variants files "

1371bf1

This reverts commit 6d7617b.

Add variants files

7428b13

Variants files for Blocks printers that include nozzle and print core variants SettingVersion updated to work with Cura 5.0

Add quality files

e49a574

Quality setting files for Blocks printers for nozzle and print core variants SettingVerison updated to work with Cura 5.0

Edited definitions files

15c7a98

Edited start Gcode of Blocks Zero and Blocks R21

R21 definition file fixed

228da72

Updated Start GCODE

nallath previously requested changes Sep 15, 2022

View reviewed changes

braga-dev and others added 8 commits October 14, 2022 17:33

Definition Blocks Files

a70c773

Update Blocks Extruder Files

1f12e42

Update Meshes Blocks Printers

247d05e

Update Blocks Global Files

b39a00b

Update Global Files

7610d92

Update Standard Files

27b9c1e

Update Blocks Variants

01fb120

Update resources/definitions/blocks_pros30.def.json

5a05f8e

Co-authored-by: Jaime van Kessel <nallath@gmail.com>

Joeydelarago added the PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions label Nov 11, 2022

Joeydelarago assigned jellespijker Nov 18, 2022

github-actions bot previously requested changes Dec 30, 2022

View reviewed changes

braga-dev and others added 2 commits December 30, 2022 11:10

Apply suggestions from code review

8334745

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Applied printer-linter format

a8ef4e2

Merge branch 'main' into blockstech

e8a5751

jellespijker closed this Dec 30, 2022

jellespijker reopened this Dec 30, 2022

jellespijker added 6 commits December 30, 2022 23:19

Merge branch 'main' into blockstech

85201e7

Moved block variants to their own specific folder

ee58dce

Improves readability

Applied printer-linter formatting

5f5e758

Contributes to CURA-10101

Use the correct stl file

c2e5246

Contributes to CURA-10101

Fixed wrong extruder number mismatch

db8aa5b

Contributes to CURA-10101

jellespijker requested changes Dec 30, 2022

View reviewed changes

jellespijker marked this pull request as draft December 30, 2022 23:24

braga-dev added 3 commits January 6, 2023 18:27

Merge pull request #1 from Ultimaker/blockstech

52aed18

Blockstech

Delete blocks_oneauto_extruder_0.def.json

2c4b4eb

Merge branch 'Ultimaker:main' into master

63a1994

jellespijker marked this pull request as ready for review January 7, 2023 12:24

jellespijker approved these changes Jan 10, 2023

View reviewed changes

jellespijker merged commit a28fc03 into Ultimaker:main Jan 10, 2023

		"speed_wall": { "value": "speed_print / 2" },
		"speed_wall_0": { "value": "speed_wall" },

		"speed_topbottom": { "value": "speed_print / 2" },
		"speed_roofing": { "value": "speed_topbottom" },

		"line_width": { "value": "machine_nozzle_size" },
		"wall_line_width": { "value": "machine_nozzle_size" },

Uh oh!

Conversation

jgrilo-blocks commented Mar 7, 2022

Uh oh!

Ghostkeeper commented Mar 16, 2022

Uh oh!

jgrilo-blocks commented Mar 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ghostkeeper commented Mar 23, 2022

Uh oh!

braga-dev commented Jun 22, 2022

Uh oh!

nallath left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

braga-dev commented Oct 14, 2022

Uh oh!

braga-dev commented Nov 5, 2022

Uh oh!

jellespijker commented Nov 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

braga-dev commented Dec 19, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

braga-dev commented Dec 30, 2022

Uh oh!

jellespijker left a comment

Choose a reason for hiding this comment

Uh oh!

jellespijker commented Jan 6, 2023

Uh oh!

braga-dev commented Jan 6, 2023

Uh oh!

jellespijker commented Jan 6, 2023

Uh oh!

jellespijker commented Jan 6, 2023

Uh oh!

braga-dev commented Jan 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jellespijker left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

jgrilo-blocks commented Mar 16, 2022 •

edited

Loading

jellespijker commented Nov 29, 2022 •

edited

Loading

braga-dev commented Jan 6, 2023 •

edited

Loading