Skip to content

feat: display macro arguments on keys #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mondalaci merged 1 commit into from
Feb 1, 2026
Merged

feat: display macro arguments on keys #2837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/uhk-web/src/app/components/svg/keys/svg-keyboard-key/svg-keyboard-key.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,9 +512,24 @@ export class SvgKeyboardKeyComponent implements OnChanges, OnDestroy {
const keyAction: PlayMacroAction = this.keyAction as PlayMacroAction;
const macro: Macro = this.macroMap.get(keyAction.macroId);
this.labelType = LabelTypes.IconText;
let macroName = macro.name;

if (keyAction.macroArguments.length > 0) {
macroName += '(';
let first = true;
for (const macroArgument of keyAction.macroArguments) {
if (!first) {
macroName += ', ';
}
macroName += macroArgument.value;
first = false;
}
macroName += ')';
}

this.labelSource = {
icon: this.mapper.getIcon('macro'),
text: macro.name
text: macroName
};
} else if (this.keyAction instanceof MouseAction) {
this.labelType = LabelTypes.MouseKey;
Expand Down