Skip to content

introduction of macroArg command #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mhantsch wants to merge 50 commits into
base: master
Choose a base branch
from
Draft

introduction of macroArg command #1481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
94852f5
Fix compilation (bad conflict resolution)
kareltucek Jan 29, 2026
1a60818
add macroArg command (ignored for now)
mhantsch Feb 1, 2026
8d743f5
Merge branch 'UltimateHackingKeyboard:master' into master
mhantsch Feb 2, 2026
a5226b6
Merge pull request #3 from mhantsch/macroArgs-declarations
mhantsch Feb 2, 2026
befb7dc
fix params
mhantsch Feb 3, 2026
79308c1
update command hash table
mhantsch Feb 3, 2026
b3dcf7d
Merge branch 'UltimateHackingKeyboard:master' into master
mhantsch Feb 3, 2026
67e5116
Merge pull request #4 from mhantsch/macroArgs-declarations
mhantsch Feb 3, 2026
7c89196
attempt at macroArg parser
mhantsch Feb 3, 2026
aeab45c
fix? debug?
mhantsch Feb 3, 2026
1a8800d
should have read compiler warnings that already told me where I was w…
mhantsch Feb 3, 2026
f003bf6
Merge pull request #5 from mhantsch/macroArgs-declarations
mhantsch Feb 3, 2026
4a944e1
improved error messages
mhantsch Feb 3, 2026
20d37d3
message beautification
mhantsch Feb 3, 2026
adcb032
Merge pull request #6 from mhantsch/macroArgs-declarations
mhantsch Feb 3, 2026
12cb31a
Merge pull request #7 from UltimateHackingKeyboard/master
mhantsch Feb 3, 2026
499395f
Merge branch 'UltimateHackingKeyboard:master' into macroArgs-declarat…
mhantsch Feb 3, 2026
563f0d1
Merge pull request #8 from mhantsch/macroArgs-declarations
mhantsch Feb 3, 2026
e2735e5
Fix gperf token vs argument expansion bug.
kareltucek Feb 3, 2026
457132f
Merge pull request #1475 from UltimateHackingKeyboard/fix/gperf-arg-e…
kareltucek Feb 3, 2026
ac3b92e
Merge branch 'UltimateHackingKeyboard:master' into master
mhantsch Feb 3, 2026
b008126
Merge branch 'UltimateHackingKeyboard:master' into master
mhantsch Feb 4, 2026
fd9cdfb
Merge branch 'UltimateHackingKeyboard:master' into macroArgs-declarat…
mhantsch Feb 4, 2026
00e1b39
Merge pull request #9 from mhantsch/macroArgs-declarations
mhantsch Feb 4, 2026
402af51
too memory intensive implementation of macro arguments storage, needs…
Feb 4, 2026
227f200
Merge branch 'UltimateHackingKeyboard:master' into master
mhantsch Feb 5, 2026
877f3b4
allow macroArg command only at start of macro
Feb 5, 2026
aa954e7
Merge pull request #11 from UltimateHackingKeyboard/master
mhantsch Feb 5, 2026
f5f3302
fix typo
Feb 5, 2026
e09686d
Merge branch 'macroArgs-declarations' of https://github.com/mhantsch/…
Feb 5, 2026
b81f9b3
actually return the return value
Feb 5, 2026
9239daa
figure why some parsing broke
mhantsch Feb 6, 2026
8da0330
fix the reachable unreachable case
mhantsch Feb 6, 2026
ab5c432
introducing MacroResult_None to fix 'if' commands that need to contin…
mhantsch Feb 6, 2026
d604381
macroArgs only allowed at beginning of macro, refactor of processCommand
mhantsch Feb 6, 2026
b2a3cd8
Merge branch 'UltimateHackingKeyboard:master' into master
mhantsch Feb 6, 2026
458afe1
removing unused code
Feb 6, 2026
b508166
Merge branch 'UltimateHackingKeyboard:master' into master
mhantsch Feb 6, 2026
2b98925
cleaner handling of returns from dispatching, especially for header c…
Feb 6, 2026
e51d414
syntax fix
Feb 6, 2026
5c9f7c2
Macro args declarations: better dispatching return logic
mhantsch Feb 6, 2026
d540053
moving arg storage, but I'm not happy yet
Feb 6, 2026
aa66476
refactor & fix ConsumeUntilDot
mhantsch Feb 7, 2026
f1d866b
fix typo
mhantsch Feb 7, 2026
04d5aad
fix typo
mhantsch Feb 7, 2026
a5f6ff6
Macro args declarations, refactor
mhantsch Feb 7, 2026
36ff834
simplify processMacroArgCommand; refrain from accessing *ctx->at dire…
mhantsch Feb 8, 2026
3c96cec
refactor white processing for macroArg, safer check for comment
mhantsch Feb 8, 2026
902f897
simplify processMacroArgCommand; refrain from accessing *ctx->at dire…
mhantsch Feb 8, 2026
78e3aff
Merge branch 'UltimateHackingKeyboard:master' into master
mhantsch Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions right/src/macros/command_hash.gperf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ ifRegEq, CommandId_ifRegEq
ifNotRegEq, CommandId_ifNotRegEq
ifRegGt, CommandId_ifRegGt
ifRegLt, CommandId_ifRegLt
macroArg, CommandId_macroArg
mulReg, CommandId_mulReg
noOp, CommandId_noOp
notify, CommandId_notify
Expand Down
1 change: 1 addition & 0 deletions right/src/macros/command_ids.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ typedef enum {
CommandId_ifRegLt, // deprecated

// 'm' commands
CommandId_macroArg,
CommandId_mulReg, // deprecated

// 'n' commands
Expand Down
Loading