Make linebreak timings optional#89
Merged
marwin89 merged 1 commit intoUltraStar-Deluxe:mainfrom May 22, 2025
Merged
Conversation
See UltraStar-Deluxe#64. Notes are already required to be ordered by start beat.
codello
force-pushed
the
optional-end-of-phrase-beats
branch
from
3fa0c41 to
5ae8d5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a change to v2 of the song format that makes the
start-beatof end-of-phrase markers optional. For example the following would be valid in v2:This requires notes to be sorted according to their
start-beattimes, which is already the case in the current v2 draft.Closes Issue(s)
Fixes #64
Motivation
See #64 (comment)
This is mostly a convenience feature for song creators.
More
This PR only targets v2 of the song format as this is a breaking change in v1.