Fix units for #END header#91
Merged
marwin89 merged 1 commit intoUltraStar-Deluxe:mainfrom May 23, 2025
Merged
Conversation
The spec incorrectly describes the `#END` header as using seconds as a unit. It is actually in milliseconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the units used for the
#ENDheader in the unversioned and v1 format.Closes Issue(s)
Fixes #90
Motivation
The spec incorrectly describes the
#ENDheader as using seconds as a unit. It is actually in milliseconds. See #90.Additional Notes
This PR targets both v1 and the unversioned format. I think it is worth to apply this change to the unversioned format as well, even though it is archived. I wouldn't want to have wrong information in the current revision of any of the versions.