Conversation
Catch BadImageFormatException in Baml Paring
UlyssesWu
left a comment
There was a problem hiding this comment.
Thanks for the PR, but since you've catched all kinds of Exception, you should throw for other types, otherwise it will turn to a NullReferenceException which is confusing.
| { | ||
| Console.WriteLine("This resource can not be parsed."); | ||
| return resource; | ||
| } |
There was a problem hiding this comment.
For other types of Exception, just throw;
| Console.WriteLine("This resource can not be parsed."); | ||
| //throw; | ||
| return; | ||
| } |
There was a problem hiding this comment.
For other types of Exception, just throw;
|
Hi whit latest dnlib of May 30, 2024 and latest compiled ASNR on my dll Target I have this issue : .\ASNR.exe .\xxxx.dll my PR Resolve this issue..... Regards |
Catch BadImageFormatException in Baml Paring