Skip to content

Gh/neyunse/dev #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neyunse merged 2 commits into from
Aug 5, 2025
Merged

Gh/neyunse/dev #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
140e47e
ci: update build-multiplatform.yml
neyunse Aug 5, 2025
d224ae1
ci: update build-multiplatform.yml
neyunse Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/build-multiplatform.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,17 @@ jobs:
& "C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\signtool.exe" sign /f cert.pfx /p "${{ secrets.VNE_KEY }}" /tr http://timestamp.digicert.com /td sha256 /fd sha256 dist/engine.exe
& "C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\signtool.exe" sign /f cert.pfx /p "${{ secrets.VNE_KEY }}" /tr http://timestamp.digicert.com /td sha256 /fd sha256 dist/lib/win/bootstrapper.exe
shell: pwsh

- name: ZIP (Windows)
run: |
Compress-Archive -Path dist\\* -DestinationPath dist\\vne-win.zip
shell: pwsh

- name: Upload Artifacts
uses: actions/upload-artifact@v4
with:
name: dist-windows
path: dist
path: dist/vne-win.zip
- name: delete cert files
run: |
del cert.pfx
Expand Down Expand Up @@ -77,12 +83,11 @@ jobs:
- name: Build engine and bootstrapper
run: |
python build.py
# incluye el firmado aqui de engine.exe y /lib/bootstrapper.exe
- name: Upload Artifacts
uses: actions/upload-artifact@v4
with:
name: dist-linux
path: dist
path: dist/vne-linux.zip
Copy link

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Linux job references 'dist/vne-linux.zip' but there is no corresponding ZIP creation step for Linux builds like there is for Windows. This will cause the artifact upload to fail as the ZIP file doesn't exist.

Copilot uses AI. Check for mistakes.

# Temporarily disabled
# build-mac:
Expand Down