Skip to content

ci: update build.yml #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neyunse merged 1 commit into from
Aug 8, 2025
Merged

ci: update build.yml #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jobs:

build-extension:
runs-on: ubuntu-22.04
needs: create-release
needs: build-linux
Copy link

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change creates a circular dependency. The build-extension job now depends on build-linux, and create-release depends on both build-linux and build-extension. However, the original dependency chain showed build-extension depending on create-release. This circular reference will cause the workflow to fail.

Copilot uses AI. Check for mistakes.
steps:
- uses: actions/checkout@v3
- name: Install Node.js
Expand All @@ -142,7 +142,7 @@ jobs:

create-release:
runs-on: ubuntu-22.04
needs: [build-windows, build-linux]
needs: [build-windows, build-linux, build-extension]
steps:
- uses: actions/checkout@v3
- name: Extract engine version
Expand Down
Loading