Handled nested JSON, added new switch for pulling additional domains from censys.io. #20
Open
pl77 wants to merge 4 commits intoUnaPibaGeek:masterfrom
Open
Handled nested JSON, added new switch for pulling additional domains from censys.io. #20pl77 wants to merge 4 commits intoUnaPibaGeek:masterfrom
pl77 wants to merge 4 commits intoUnaPibaGeek:masterfrom
Conversation
Also PEP8ified formatting and updated script version number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the "names" key on the censys.io certificate records, this optional update provides additional hits for some crt.sh records that don't have very many.
It remains optional because it can add a lot of times to a search, especially with very large sites, and some of the responses are less relevant than those from crt.sh.
This should be backward compatible with the existing script and users are not required to install additional dependencies if they do not want the functionality. If they do want the functionality, a single import, BeautifulSoup4, is required. Users will be prompted to install it if it does not already exist.