feat: nullable temporary_url_duration for permanent public urls on S3 #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…permanent public urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(optional) Issue number:
N/A
Summary of the change:
This PR allows users to set
temporary_url_durationtonullto enable permanent URL generation for S3.Currently, if the user has specified an S3 filesystem, they must use temporary URLs. However, there are cases where a user may not want this. For example, when using LFM with Nova TInyMCE I have a use-case where the image URLs will be saved into content pages' text blocks. The requirement of generating a temporary URL doesn't really make sense in this context, so enabling a permanent URL to be saved into the database is the solution.
Thanks!