Control logging through options.logging param#181
Open
vladimyr wants to merge 2 commits intoUnitech:masterfrom
Open
Control logging through options.logging param#181vladimyr wants to merge 2 commits intoUnitech:masterfrom
options.logging param#181vladimyr wants to merge 2 commits intoUnitech:masterfrom
Conversation
- implementing `options.logging` that defaults to `console.log`; updating tests to use `options.logging = false;` - updating docs - swapping map + join with single pass reduce
|
update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces optional
optionsparam todeployForEnvfunction changing its signature to:(It is an optional param, so there is no fear in breaking existing usage pattern which will simply default to
console.logas expected.)This enables control of logging behavior from outside instead of hardcoding
console.logcalls 🔧