Skip to content

Fix instance ids #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sim-bz merged 2 commits into from
Mar 16, 2026
Merged

Fix instance ids #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d096d4
Fixed remaining instanceIDs issues.
sim-bz Mar 16, 2026
fdb1e87
Bumped version to 2.10.7
sim-bz Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions com.unity.cinemachine/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ All notable changes to this package will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [2.10.7] - 2026-03-16

- Converted code using InstanceID references and API to EntityID.

## [2.10.6] - 2026-02-23

Expand Down
4 changes: 4 additions & 0 deletions com.unity.cinemachine/Runtime/Behaviours/CinemachineStoryboard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,11 @@ protected override void ConnectToVcam(bool connect)
DestroyCanvas();
}

#if UNITY_6000_3_OR_NEWER
string CanvasName => "_CM_canvas" + gameObject.GetEntityId();
#else
string CanvasName => "_CM_canvas" + gameObject.GetInstanceID();
#endif
Comment on lines +196 to +200
Copy link
Copy Markdown
Contributor

@u-pr u-pr bot Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low
The CanvasName property performs string concatenation every time it is accessed. Since the ID of the gameObject remains constant during its lifetime, have you considered caching this string in a private field (e.g., initialized in Awake or lazily)? This would avoid unnecessary heap allocations if the property is accessed frequently during camera updates or UI refreshes.

🤖 Helpful? 👍/👎


void CameraUpdatedCallback(CinemachineBrain brain)
{
Expand Down
2 changes: 1 addition & 1 deletion com.unity.cinemachine/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "com.unity.cinemachine",
"displayName": "Cinemachine",
"version": "2.10.6",
"version": "2.10.7",
"unity": "2022.3",
"description": "Smart camera tools for passionate creators. \n\n--- ATTENTION ---\nUpgrading a project from Cinemachine 2.x to Cinemachine 3.x is not automatic and not trivial.\nDon't do it unless you're willing to put in the required effort.\n\n> For more details, refer to the upgrade guide:\nhttps://docs.unity3d.com/Packages/com.unity.cinemachine@3.1/manual/CinemachineUpgradeFrom2.html\n--------------------\n\n\n",
"keywords": [ "camera", "follow", "rig", "fps", "cinematography", "aim", "orbit", "cutscene", "cinematic", "collision", "freelook", "cinemachine", "compose", "composition", "dolly", "track", "clearshot", "noise", "framing", "handheld", "lens", "impulse" ],
Expand Down
Loading