Skip to content

Idlelock timer reset notification#630

Open
simonLeary42 wants to merge 28 commits intomainfrom
idlelock-timer-reset-notification
Open

Idlelock timer reset notification#630
simonLeary42 wants to merge 28 commits intomainfrom
idlelock-timer-reset-notification

Conversation

@simonLeary42
Copy link
Member

@simonLeary42 simonLeary42 commented Feb 26, 2026

  • added a confirmation message when the inactivity timer is reset and the user /may have been/ notified by email
    • if they reach exactly N days idle at 2PM, and they login at 3PM, and user-expiry.php won't run until tomorrow at 2AM, then the user will get a confirmation message despite not having been emailed
    • this message is mutually exclusive with the "idlelock removed" message, and cannot be sent if the user is disabled
  • added a function convertLastLoginToIdleDays so that there can be no discrepancies between the logic of user-expiry.php and the confirmation message in init.php
  • moved the locked group enforcement to header.php next to the disabled group enforcement
  • updated the test cases for locked group enforcement to run on all pages
  • fixed a bug where a disabled user can get an "idle unlocked" confirmation message
  • refactored test files, so instead of (ExpiryTest ExpiryApiTest IdleUnlockTest) we now have (ExpiryWorkerTest ExpiryApiTest ExpiryGuiTest)

@simonLeary42 simonLeary42 force-pushed the idlelock-timer-reset-notification branch from 066b19d to 2f3aa18 Compare February 27, 2026 18:27
@simonLeary42 simonLeary42 force-pushed the idlelock-timer-reset-notification branch from 2f3aa18 to bd54482 Compare February 27, 2026 18:28
@simonLeary42 simonLeary42 marked this pull request as ready for review February 27, 2026 20:43
@simonLeary42 simonLeary42 mentioned this pull request Feb 27, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants