Skip to content

Conversation

@rotkiv93
Copy link
Collaborator

@rotkiv93 rotkiv93 commented Sep 9, 2025

After the refactoring changes made in #60 , introduced some regex errors, containing blanks spaces in the float number definitions and other minor errors

@rotkiv93
Copy link
Collaborator Author

rotkiv93 commented Sep 9, 2025

I didnt actually check for changes in the lexer/parsers for the specific languages (js, java, python), maybe its worth checking those in this PR

@gravemalte
Copy link
Member

@rotkiv93 Thanks for the changes. Yeah please, everything you spot, change it. I rewrote large part of the grammar, I knew I would miss some things. We need to catch them now.

@gravemalte
Copy link
Member

Also, please be sure to test it with the https://github.com/Universal-Variability-Language/java-fm-metamodel/tree/main test suite

@jmhorcas
Copy link

jmhorcas commented Sep 9, 2025

An additional note:

The following regex about STRING was an old issue (issue #47 ) already fixed some months ago to allow using the dot '.' within String attributes.
STRING: '\''~[\r\n'.]+'\'';
In this new version the issue appears again because the dot it's not allowed anymore again.
The correct regex would be:
STRING: '\''~[\r\n']+'\'';

without the dot!!

Be careful because the following regex is correct as it is:

ID_NOT_STRICT: '"'~[\r\n".]+'"';

This one is correct.

In summary: do not allow dot inside ID for features, but allow dot inside String attributes.

@SundermannC SundermannC changed the base branch from main to issue-64 September 24, 2025 11:42
@SundermannC
Copy link
Member

Thanks a lot for your work and comments so far! I will merge this to a dedicated branch and resolve remaining issues there.

@SundermannC SundermannC merged commit 68c1ed6 into issue-64 Sep 24, 2025
4 of 7 checks passed
SundermannC added a commit that referenced this pull request Sep 24, 2025
SundermannC pushed a commit that referenced this pull request Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regular expressions in the new version of the grammar are wrong

5 participants