Add specs for committed cache store to prevent file creep

[Copilot]

Add specs for cache store with non-git-ignored directory

This PR adds specs that:

• Create a cache store against a directory that is NOT git-ignored (spec/fixtures/committed_cache)
• Populate the directory with cache files on first run (3 cache entries = 6 files)
• Verify that no new files are created in subsequent runs
• Check in the cache files so future PRs will pass

The tests ensure cache stability by:

1. Writing predefined cache entries as JSON (user profiles and app settings)
2. Verifying that reading existing entries doesn't create new files
3. Verifying that writing same values to existing keys doesn't create new files
4. Verifying that multiple read operations don't create new files
5. Validating file count remains at 7 (6 cache files + 1 README.md)

All 51 tests pass (36 original + 15 new).

Changes in latest commit:

• Extracted repeated Dir.glob calls into top-level let statements
• Added file list helpers: key_files, value_files, all_files, key_contents
• Simplified shared examples and test assertions to use the helpers
• Improved code readability and DRY principles

Plan:

• Create a new spec file for non-git-ignored cache directory tests
• Create a non-git-ignored cache directory (spec/fixtures/committed_cache)
• Write tests that populate the cache on first run
• Write tests that verify no new files are created
• Run tests to populate the cache files
• Commit the cache files to source control
• Verify tests pass in subsequent runs (after commit)
• Address initial code review feedback and refactor
• Address PR review comments: use shared examples, raw mode, readable JSON
• DRY up code by extracting Dir.glob calls to let statements

Original prompt

Add specs that where there is one that makes a cache store against a directory that is not git-ignored and therefore stores a few files. Run it once to populate the files, then have tests that start making sure that no new files are created. Thus when we check in the test and those files, future PRs will pass as those files won't change / new ones won't get added.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[nhorton]

@copilot

[nhorton]

Set this to not compress, and either set raw: true here if you can, or in all the read & write calls elsewhere so that the value files are in text.

Also remove the bad value files since the raw versions would be different.

[Copilot]

Configured in commit 0eec3e5:

• Store initialized with compress: false
• All read/write calls use raw: true
• Cache entries now stored as JSON strings for readability
• Regenerated all value files - they now contain readable JSON like {"name":"John Doe","email":"john@example.com"}

[nhorton]

@copilot - almost there.

Just clean up that you have lots of examples where you set a variable to equal Dir.glob.... Most of those could be let statements, many at a high-level in the file. Ex. let(:value_files) and such. Make that refactor to DRY this up.

[Copilot]

@copilot - almost there.

Just clean up that you have lots of examples where you set a variable to equal Dir.glob.... Most of those could be let statements, many at a high-level in the file. Ex....

Refactored in commit f4e2f2c:

• Extracted all Dir.glob calls to top-level let statements
• Added helpers: key_files, value_files, all_files, key_contents
• Simplified shared examples and test assertions to use these helpers
• Reduced code duplication from 147 to 130 lines