Open
Conversation
… working as wanted, with some small ux and styling changes likely warranted.
Collaborator
outragedhuman
left a comment
outragedhuman
left a comment
There was a problem hiding this comment.
See comments, also:
- There seems to be a bug on the search box where it's always showing up as if its
:hoveris active? Like it has a white outline all the time.
| url: string; | ||
| } | ||
|
|
||
| const placeHolderVals = [{ title: "test" }, { title: "hello" }]; |
Collaborator
There was a problem hiding this comment.
I'm assuming placeholders are no longer needed?
| ); | ||
|
|
||
| useEffect(() => { | ||
| console.log("render"); |
|
|
||
| // Placeholder values for the autocomplete | ||
| const placeHolderVals = ["test", "hello"]; | ||
| const placeHolderVals = [{ title: "test" }, { title: "hello" }]; |
Collaborator
There was a problem hiding this comment.
similar to above, can placeholdervals be removed?
Collaborator
|
@vwalsh I made some comments on this a while back. I still need to do some more testing on this so let me know when you've had a chance to look at the comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search bar now works in some basic ways. consider:
WIP until most of the above is resolved and confirmed this implementation is adequate.