Skip to content

Comments

Runes migration#163

Merged
mitchthorson merged 50 commits intomainfrom
patch-runes-migrate
Oct 30, 2025
Merged

Runes migration#163
mitchthorson merged 50 commits intomainfrom
patch-runes-migrate

Conversation

@mitchthorson
Copy link
Contributor

@mitchthorson mitchthorson commented Oct 16, 2025

What's in this pull request

  • Other

Description

This pull request contains a library-wide refactor toward Svelte 5 runes syntax across all Svelte components and documentation. Functionality is left unchanged, except where bugs or inconsistencies were fixed as part of this migration. This should behave just as the library did before, with just a few breaking changes related to moving away from Svelte Stores for shared state.

Note that generative AI tools were used to assist with this refactor, including Anthropic's Claude Code CLI and Open AI's Codex CLI. Every change has been manually reviewed and verified by a human developer through multiple rounds of careful review.

Before submitting, please check that you've

  • Formatted your code correctly (i.e., prettier cleaned it up)
  • Documented any new components or features
  • Added any changes in this PR to the CHANGELOG.md Next section
  • If this pull request includes a new component or feature, has it been exported from one of the library's entry points?
  • Does the component directory include description and usage information in .stories.svelte?

@mitchthorson mitchthorson marked this pull request as ready for review October 16, 2025 19:26
Copy link
Contributor Author

@mitchthorson mitchthorson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've re-reviewed each of these changes and made a few slight adjustments.

@rachelmarconi
Copy link
Contributor

truly last thing and feel free to ignore -- in almost all cases (except SvgPointLayer, SvgPolygonLayer and SvgLabelLayer), the controls panel has bulleted descriptions in the second column above the types. I'm trying to track down what changed since this is new but oddly inconsistent -- it's not like the maps subfolder has a different controls or autodocs template.
Screenshot 2025-10-24 at 12 06 07 PM

@mitchthorson
Copy link
Contributor Author

Ok, all of these review notes have been resolved. Thank you for your time and energy on this @rachelmarconi. Going to rebase and merge.

@mitchthorson mitchthorson merged commit 1d1ed97 into main Oct 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants