Refactor R catalog code into modular architecture#75
Merged
Thiyaghessan merged 2 commits intomainfrom Jan 20, 2026
Merged
Conversation
- Create modular R structure in catalogs/R/: - config.R: Centralized constants, URLs, regex patterns - validators.R: Input validation with informative errors - extractors.R: Year/month/path extraction and filtering - url_builders.R: S3 and archive URL construction - buttons.R: HTML button generation - catalog_builders.R: Series-specific catalog building - nccs_catalog.R: Main entry point - Add shared Quarto config (catalogs/_quarto.yml) with: - Consolidated library directory (_shared-libs) - Shared CSS styles (catalogs/styles/catalog.css) - Add testing infrastructure: - GitHub Actions CI workflow (.github/workflows/build.yml) - testthat tests for R functions (catalogs/tests/) - Add JSDoc documentation to all JS modules - Fix CSS syntax error in www/header.html - Add .gitattributes for generated files - Clean up dead code in build-catalogs.R - Simplify catalog .qmd files to use shared config Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create modular R structure in catalogs/R/:
Add shared Quarto config (catalogs/_quarto.yml) with:
Add testing infrastructure:
Add JSDoc documentation to all JS modules
Fix CSS syntax error in www/header.html
Add .gitattributes for generated files
Clean up dead code in build-catalogs.R
Simplify catalog .qmd files to use shared config