Add some auto defaults + updated electron version #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should work but I haven't tested it. Added a dynamic Electron Version by seeing if its in dependencies, dev dependencies and falling back to v7.1.5. Added a dynamic version check by using the version in the package.json falling back to v0.0.1. Added a default icon file, which is where I store my icon as well as I've seen someone else do so. This change is more for my convenience but it is a smart place to save your icon.
WilsontheWolf
commented
Mar 4, 2020
| electronVersion: '1.6.15', | ||
| electronVersion: getElectronVersion(), | ||
| version: getPackageVersion(), | ||
| defaultIcon: path.join(process.cwd(), 'assets', 'icon.ico'), |
Author
There was a problem hiding this comment.
This is the path I use for my icons. You may remove this if you wish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work but I haven't tested it.
Basically it adds some features which make using this easier.
Added a dynamic Electron Version by seeing if its in dependencies, dev dependencies and falling back to v7.1.5.
Added a dynamic version check by using the version in the package.json falling back to v0.0.1.
Added a default icon file, which is where I store my icon as well as I've seen someone else do so. This change is more for my convenience but it is a smart place to save your icon.