Use OpenStreetMap as a source for the land-sea-mask#31
Draft
LucasChollet wants to merge 1 commit intoVBoulenger:masterfrom
Draft
Use OpenStreetMap as a source for the land-sea-mask#31LucasChollet wants to merge 1 commit intoVBoulenger:masterfrom
LucasChollet wants to merge 1 commit intoVBoulenger:masterfrom
Conversation
This mask is much more accurate than SRTM. But, when using another source the Land-Sea-Mask operator does not consider shorelineExtension. Which mean that we are stuck with any issue that the new mask has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative solution to the issue #29 tries to solve, only one of both solution should be merged.
It is a draft for now, as we should retrieve the source file automatically and not hardcode the path.
The mask comes from OpenStreetMap is much more accurate than SRTM. But, when using another source, the Land-Sea-Mask operator does not consider shorelineExtension. Which mean that we are stuck with any issue that the new mask has.
On the same tile as #29, the number of detection drops to 490 (330 fewer detections):
The mask:
