Skip to content

Change default file permission from 'r' to 'rb' (binary mode) #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevewds merged 2 commits into from
Mar 30, 2026

Fix test and binarydoc_matfid to use 'rb' permission

a180db3
Select commit
Loading
Failed to load commit list.
Merged

Change default file permission from 'r' to 'rb' (binary mode) #117

Fix test and binarydoc_matfid to use 'rb' permission
a180db3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 30, 2026 in 1s

45.63% (+0.00%) compared to 740b5c4

View this Pull Request on Codecov

45.63% (+0.00%) compared to 740b5c4

Details

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.63%. Comparing base (740b5c4) to head (a180db3).

Files with missing lines Patch % Lines
src/did/+did/+file/fileobj.m 33.33% 2 Missing ⚠️
src/did/+did/+file/readonly_fileobj.m 50.00% 2 Missing ⚠️
src/did/+did/+implementations/binarydoc_matfid.m 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   45.63%   45.63%           
=======================================
  Files          55       55           
  Lines        3158     3158           
=======================================
  Hits         1441     1441           
  Misses       1717     1717

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov