Skip to content

Fix numeric type casting in binary matrix read operations #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevevanhooser merged 1 commit into from
Apr 8, 2026
+6 −6
Merged

Fix numeric type casting in binary matrix read operations #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions +ndr/+format/+binarymatrix/read.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,13 @@
bytes_per_value = bits / 8;
end;

total_samples = (d.bytes-double(options.headerSkip)) / (num_channels * bytes_per_value);
total_samples = (d.bytes-double(options.headerSkip)) / (double(num_channels) * bytes_per_value);

if isinf(s1) & (s1>0),
s1 = total_samples;
end;

bytes_per_sample = bytes_per_value * num_channels;
bytes_per_sample = bytes_per_value * double(num_channels);

channel_indexes = channel_indexes(:); % force column

Expand All @@ -109,8 +109,8 @@
fid = fopen(filename_or_fileobj,'r',options.byteOrder);

if ~options.force_single_channel_read & consecutive_channels_requested,
channels_to_skip_before_reading = chan_sort(1) - 1;
channels_to_skip_after_reading = num_channels - chan_sort(end);
channels_to_skip_before_reading = double(chan_sort(1) - 1);
channels_to_skip_after_reading = double(num_channels - chan_sort(end));

skip_point = double(options.headerSkip) + ...
(s0-1)*bytes_per_sample + ... % skip to the sample ...
Expand All @@ -130,8 +130,8 @@
else,
data = zeros(s1-s0+1,numel(channel_indexes));
for c=1:numel(channel_indexes),
channels_to_skip_before_reading = channel_indexes(c) - 1;
channels_to_skip_after_reading = num_channels - channel_indexes(c);
channels_to_skip_before_reading = double(channel_indexes(c) - 1);
channels_to_skip_after_reading = double(num_channels - channel_indexes(c));

skip_point = double(options.headerSkip) + ...
(s0-1)*bytes_per_sample + ... % skip to the sample ...
Expand Down
Loading