Skip to content

Fix zip failures on Windows in GitHub Actions workflow #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevevanhooser merged 1 commit into from
Feb 22, 2026
Merged

Fix zip failures on Windows in GitHub Actions workflow #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/build_and_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,11 @@ jobs:
run: |
mkdir -p dist
if [ "${{ runner.os }}" == "Windows" ]; then
# Windows CMake builds output to bin due to our CMakeLists.txt fix
zip -j dist/pyraview-win-x64.zip build/bin/*.dll build/bin/*.exe
elif [ "${{ runner.os }}" == "macOS" ]; then
zip -j dist/pyraview-mac-arm.zip build/bin/*.dylib build/bin/run_tests
# Use 7-Zip (pre-installed on Windows runners)
# 'a' is add, '-j' junk paths (like zip -j)
7z a -tzip dist/pyraview-win-x64.zip ./build/bin/*.dll ./build/bin/*.exe
else
zip -j dist/pyraview-linux-x64.zip build/bin/*.so build/bin/run_tests
zip -j dist/pyraview-${{ runner.os }}-${{ runner.arch }}.zip build/bin/*
fi

- name: Upload Artifacts
Expand Down