-
Notifications
You must be signed in to change notification settings - Fork 198
feat(Box): add system paddings #9388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EldarMuhamethanov
wants to merge
3
commits into
master
Choose a base branch
from
e.muhamethanov/9254/padding-system
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+143
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9388/ee9c21b5ad4f086b6319a37353ab30331cfdf4d4/pkg/@vkontakte/vkui/_pkg.tgzCommit ee9c21b |
SevereCloud
previously approved these changes
Jan 22, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9388 +/- ##
==========================================
- Coverage 94.73% 94.72% -0.01%
==========================================
Files 440 440
Lines 11898 11916 +18
Branches 4386 4394 +8
==========================================
+ Hits 11271 11287 +16
- Misses 627 629 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paddingзначениемsystem#9254Описание
Добавлена поддержка специального значения
'system'для всех padding-свойств в компонентах раскладки (Box, Flex, SimpleGrid и др.). Это значение автоматически устанавливает системные отступы VKUI, которые зависят от платформы (--vkui--size_base_padding_vertical--regularи--vkui--size_base_padding_horizontal--regular).Данное изменение упрощает миграцию с устаревшего компонента
DivнаBox, так как теперь не нужно вручную указывать CSS-переменные для системных отступов.Release notes
Улучшения
'system'для всех padding-свойствЗначение
'system'автоматически устанавливает системные отступы VKUI (--vkui--size_base_padding_vertical--regularи--vkui--size_base_padding_horizontal--regular), что упрощает миграцию с устаревшего компонентаDivнаBox. Поддерживается использование как для всех отступов (padding="system"), так и для отдельных осей (paddingBlock="system",paddingInline="system"и их start/end вариантов).