Skip to content

Conversation

@pajecawav-vk
Copy link

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Каждый вызов useAdaptivityWithJSMediaQueries в SSR генерировал ворнинг который засорял логи, поправил console.error на warnOnce

image

Изменения

Release notes

  • useAdaptivityWithJSMediaQueries: поправлено предупреждение о вызове хука вне браузера. Теперь предупреждение будет выводиться один раз

@pajecawav-vk pajecawav-vk requested a review from a team as a code owner January 23, 2026 14:41
@github-actions
Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions
Copy link
Contributor

📊 Найдены изменения в собранных файлах: Отчет

Commit 93c852a

@github-actions
Copy link
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9392/93c852a1341570a68324ed8fe2816aaaa17af80d/pkg/@vkontakte/vkui/_pkg.tgz

Commit 93c852a

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.73%. Comparing base (8dfd899) to head (93c852a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../vkui/src/hooks/useAdaptivityWithJSMediaQueries.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9392   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files         440      440           
  Lines       11898    11899    +1     
  Branches     4386     4386           
=======================================
+ Hits        11271    11272    +1     
  Misses        627      627           
Flag Coverage Δ
unittests 94.73% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant