Open
Conversation
Previously, build.sh checkd the version of `gcc`, picking whichever version of `gcc` comes first in a user's `PATH`. However, `tf_exports.sh` also allows setting a specific `gcc` path through the `GCC_HOST_COMPILER_PATH` variable. This commit changes `build.sh` to check the version of that compiler, instead of relying on `gcc` in the user's `PATH`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, build.sh checkd the version of
gcc, picking whicheverversion of
gcccomes first in a user'sPATH. However,tf_exports.shalso allows setting a specificgccpath through theGCC_HOST_COMPILER_PATHvariable.This commit changes
build.shto check the version of that compiler,instead of relying on
gccin the user'sPATH.For me, for example, this resulted in a build failure, since i had selected
gcc-4.9inGCC_HOST_COMPILER_PATH, while mygccis version 6.3. After this change, I was able to build it successfully.Best regards,
Christian