Skip to content

Docker update#82

Merged
craig8 merged 29 commits intoVOLTTRON:developfrom
ntenney:docker-update
Aug 13, 2025
Merged

Docker update#82
craig8 merged 29 commits intoVOLTTRON:developfrom
ntenney:docker-update

Conversation

@ntenney
Copy link
Copy Markdown
Contributor

@ntenney ntenney commented Apr 24, 2025

Updated to clone the volttron repo instead of copying it from the submodule. Removed the submodule. Modified the Dockerfile and Dockerfile-dev files to allow users to set the repository and branch/tag to clone. Updated the publish_develop_image.yml file to remove the submodule step. Updated the README.md documentation.

@ntenney ntenney requested a review from Copilot April 24, 2025 08:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the repository cloning method by switching from using a submodule to cloning the volttron repository directly, and adjusts related Docker and documentation configurations. Key changes include:

  • Updated Dockerfile and Dockerfile‑dev to accept repository and branch/tag build arguments.
  • Removed submodule steps from the workflow and documentation.
  • Extended platform configuration to optionally create and save web user settings.

Reviewed Changes

Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.

File Description
core/setup-platform.py Added functions to create and save web user configurations; updated unpacking of get_platform_configurations.
README.md Updated instructions to reflect the new cloning method and build process.
.github/workflows/publish_develop_image.yml Removed deprecated submodule cloning step.
Files not reviewed (4)
  • .gitmodules: Language not supported
  • Dockerfile: Language not supported
  • Dockerfile-dev: Language not supported
  • volttron: Language not supported
Comments suppressed due to low confidence (1)

core/setup-platform.py:386

  • [nitpick] For clarity and consistency with the 'get_platform_configurations' function, consider renaming the unpacked 'web_users' variable to 'web_users_params'.
config_tmp, agents_tmp, platform_cfg_tmp, web_users = get_platform_configurations(get_platform_config_path())

@ntenney ntenney closed this Apr 25, 2025
@ntenney ntenney reopened this Apr 25, 2025
@ntenney ntenney closed this May 14, 2025
@ntenney ntenney reopened this May 14, 2025
@ntenney ntenney closed this May 15, 2025
@ntenney ntenney reopened this May 15, 2025
@ntenney ntenney closed this May 15, 2025
@ntenney ntenney reopened this May 15, 2025
@ntenney ntenney closed this May 15, 2025
@ntenney ntenney reopened this May 15, 2025
@ntenney ntenney closed this May 15, 2025
@ntenney ntenney reopened this May 15, 2025
@ntenney ntenney closed this May 15, 2025
@ntenney ntenney reopened this May 15, 2025
@ntenney ntenney closed this May 15, 2025
@ntenney ntenney reopened this May 15, 2025
@craig8 craig8 merged commit cca15d9 into VOLTTRON:develop Aug 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants