Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the repository cloning method by switching from using a submodule to cloning the volttron repository directly, and adjusts related Docker and documentation configurations. Key changes include:
- Updated Dockerfile and Dockerfile‑dev to accept repository and branch/tag build arguments.
- Removed submodule steps from the workflow and documentation.
- Extended platform configuration to optionally create and save web user settings.
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/setup-platform.py | Added functions to create and save web user configurations; updated unpacking of get_platform_configurations. |
| README.md | Updated instructions to reflect the new cloning method and build process. |
| .github/workflows/publish_develop_image.yml | Removed deprecated submodule cloning step. |
Files not reviewed (4)
- .gitmodules: Language not supported
- Dockerfile: Language not supported
- Dockerfile-dev: Language not supported
- volttron: Language not supported
Comments suppressed due to low confidence (1)
core/setup-platform.py:386
- [nitpick] For clarity and consistency with the 'get_platform_configurations' function, consider renaming the unpacked 'web_users' variable to 'web_users_params'.
config_tmp, agents_tmp, platform_cfg_tmp, web_users = get_platform_configurations(get_platform_config_path())
craig8
reviewed
Apr 25, 2025
craig8
reviewed
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to clone the volttron repo instead of copying it from the submodule. Removed the submodule. Modified the Dockerfile and Dockerfile-dev files to allow users to set the repository and branch/tag to clone. Updated the publish_develop_image.yml file to remove the submodule step. Updated the README.md documentation.