Conversation
Merge main into develop
Update Volttron version to 8.2, tests, documentation, hooks
…ocker-compose.yml
… for default configurations.
Correctly updated image name to 8.2-zmq and added missing volume to d…
Updated os/version and set for 9.0 release.
Updated to show the run action for pr branches. Updated ubuntu version as 20.04 is deprecated in github.
Updated ubuntu version as 20.04 is deprected on github.
Updates to docker files to align with new volttron version
Docker update
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request modernizes the build and CI/CD infrastructure for the project, updating base images from Debian Buster to Debian Bookworm, migrating from submodule-based Volttron source management to direct Git cloning, and enhancing Docker workflows with multi-platform support.
- Migrated Dockerfiles from
amd64/debian:bustertorust:bookwormbase image with updated Python and pip handling - Replaced git submodule approach with direct Git cloning using configurable build arguments for repository and branch
- Updated CI/CD workflows to use Ubuntu 22.04 runners, latest checkout actions, and multi-platform Docker builds
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| volttron | Removed git submodule reference |
| .gitmodules | Removed submodule configuration |
| Dockerfile | Updated base image to rust:bookworm, replaced submodule copy with git clone |
| Dockerfile-dev | Updated base image to rust:bookworm, replaced submodule copy with git clone |
| run-test-docker-image.sh | Updated Docker commands, simplified parameters, improved quoting |
| docker-compose*.yml | Updated image tags and added timezone environment variable |
| core/setup-platform.py | Enhanced web user management, commented out RMQ code, improved dependency installation |
| core/bootstart.sh | Reduced Volttron logging verbosity |
| README*.md | Updated documentation for new Docker compose syntax and build process |
| .pre-commit-config.yaml | Updated black formatter version |
| .github/workflows/* | Updated to Ubuntu 22.04, actions/checkout@v4, added multi-platform builds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modernizes the build and CI/CD infrastructure for the project, focusing on updating base images, improving Dockerfile practices, and enhancing workflow flexibility and compatibility. The changes ensure the project uses more recent and secure environments, streamline the build process for multi-platform support, and improve maintainability by removing legacy submodule usage and making workflows more configurable.
Dockerfile and Build Improvements
DockerfileandDockerfile-devto use the officialrust:bookwormimage (instead ofamd64/debian:buster), added installation steps for Rust and Cargo, and updated default Python and pip handling for better compatibility with modern Python packaging. RabbitMQ installation steps are now commented out for easier maintenance. [1] [2] [3] [4].gitmodules. [1] [2] [3] [4] [5]CI/CD Workflow Updates
ubuntu-22.04runners and the latestactions/checkout@v4for improved security and compatibility. [1] [2] [3] [4] [5] [6]linux/amd64,linux/arm64) and made DockerHub login conditional based on available secrets/variables. [1] [2] [3]pull_request_targettriggers inpublish_develop_image.yml, and made image tags, repo URLs, and branches configurable via variables. [1] [2]Maintenance and Tooling
blackcode formatter version in.pre-commit-config.yamlfrom19.3b0to22.8.0for improved code style enforcement.These changes collectively improve the reliability, security, and maintainability of the build and release process.