Skip to content

feat: add shared animals, peds, and vehicles data#5

Open
lu-value wants to merge 6 commits intoVORPCORE:mainfrom
lu-value:feat-entity-data-templates
Open

feat: add shared animals, peds, and vehicles data#5
lu-value wants to merge 6 commits intoVORPCORE:mainfrom
lu-value:feat-entity-data-templates

Conversation

@lu-value
Copy link
Contributor

@lu-value lu-value commented Mar 24, 2026

Pull request template

Important

Please complete all fields. PRs will not be merged if any fields are incomplete. Be respectful, and keep in mind that it may take some time for your PR to be reviewed.

Bear in mind refactors are up to the developers and not it's contributors after all we are the ones giving support when needed. if they are big changes I suggest you to release it under your name instead.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Motive for This Pull Request

This pull request adds prepared shared data tables for animals, peds, and vehicles.

Provide a brief explanation of why these changes are being proposed and what they aim to achieve.

This PR prepares shared/data/animals.lua, shared/data/peds.lua, and shared/data/vehicles.lua so they can be imported directly through the existing import system.

Explain the necessity of these changes and how they will impact the framework or its users.

These changes provide ready-to-use shared data for model lookup. The data is structured for direct use in resources, with model-based keys and source hash values kept in the hash field.

Please describe the tests you have conducted to verify your changes. Provide instructions so we can reproduce these tests. Also, list any relevant details for your test configuration.

  • Tested with latest vorp scripts
  • Tested with latest artifacts

Notes if any

The data was prepared from femga/rdr3_discoveries and grouped heuristically for animals, peds, and vehicles. I could not test every entry, but the tests I ran worked well.

@outsider31000
Copy link
Member

I tried to add this but then I started thinking and it doesnt make sense having it here, because all that this does is giving us a string model which is not usefull for anything besides debug and a hex hash which again isnt userfull for anything
I dont see in any instance where this would be usefull to have.
so I left it until I find a good reason to have it, but so far I haven't found any xD

Does anyone think this can be usefull ? and in what scenario?

@lu-value
Copy link
Contributor Author

lu-value commented Mar 25, 2026

I tried to add this but then I started thinking and it doesnt make sense having it here, because all that this does is giving us a string model which is not usefull for anything besides debug and a hex hash which again isnt userfull for anything

I dont see in any instance where this would be usefull to have.

so I left it until I find a good reason to have it, but so far I haven't found any xD

Does anyone think this can be usefull ? and in what scenario?

I thought the same when I made the PR, but for example, for ped menus to list existing peds, I think it could be quite useful.

Maybe we could add an extra label ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants