feat: add shared animals, peds, and vehicles data#5
feat: add shared animals, peds, and vehicles data#5lu-value wants to merge 6 commits intoVORPCORE:mainfrom
Conversation
|
I tried to add this but then I started thinking and it doesnt make sense having it here, because all that this does is giving us a string model which is not usefull for anything besides debug and a hex hash which again isnt userfull for anything Does anyone think this can be usefull ? and in what scenario? |
I thought the same when I made the PR, but for example, for ped menus to list existing peds, I think it could be quite useful. Maybe we could add an extra label ? |
Pull request template
Important
Please complete all fields. PRs will not be merged if any fields are incomplete. Be respectful, and keep in mind that it may take some time for your PR to be reviewed.
Bear in mind refactors are up to the developers and not it's contributors after all we are the ones giving support when needed. if they are big changes I suggest you to release it under your name instead.
Type of change
Motive for This Pull Request
This pull request adds prepared shared data tables for animals, peds, and vehicles.
Provide a brief explanation of why these changes are being proposed and what they aim to achieve.
This PR prepares
shared/data/animals.lua,shared/data/peds.lua, andshared/data/vehicles.luaso they can be imported directly through the existing import system.Explain the necessity of these changes and how they will impact the framework or its users.
These changes provide ready-to-use shared data for model lookup. The data is structured for direct use in resources, with model-based keys and source hash values kept in the
hashfield.Please describe the tests you have conducted to verify your changes. Provide instructions so we can reproduce these tests. Also, list any relevant details for your test configuration.
Notes if any
The data was prepared from femga/rdr3_discoveries and grouped heuristically for animals, peds, and vehicles. I could not test every entry, but the tests I ran worked well.