Bump minimum VSCode version to 1.31.0 #3567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Yah, I hadn't realized there was a dependency on a particular vscode version. Oh well, live and learn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As an alternative to #3525, we should at least specify that you need VSCode 1.31.0 or newer in order for the extension to run correctly. (In all reality, I should've done this with the original CamelCaseMotion PR, but unfortunately overlooked that it was a possibility.)
This sadly won't help people who are having trouble with 1.1.0. Ideally we could unpublish that one release and the release 1.1.1 with this change included. But not sure if that's possible.