Add non-alphabetic characters to surround operations (#8895) #9525
+359
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds non alphabetic characters to surround based operations (e.g.
yi$,ysi$}). These actions are supported by vim surround, so users expect this to line up when interacting with VSCodeVim.Which issue(s) this PR fixes
Fixes #8895
Special notes for your reviewer:
I added the ability to recognize which actions match user's input with a
RegExp. I wasn't sure of a better way to specify motions which really encompass character classes, but am more than open to improving this based on any feedback.