Skip to content

Conversation

@liniiiiii
Copy link
Collaborator

add a zip file of the shape files for country and states

@liniiiiii liniiiiii requested a review from i-be-snek October 3, 2024 07:39
Copy link
Collaborator

@i-be-snek i-be-snek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I unzipped the file and it seems to work fine. Is there anything you need to add to this? Maybe citing where you got these visualization maps from (website/paper/project)?

Otherwise approved :)

@liniiiiii
Copy link
Collaborator Author

I unzipped the file and it seems to work fine. Is there anything you need to add to this? Maybe citing where you got these visualization maps from (website/paper/project)?

Otherwise approved :)

for all of them, I plan to add readme in the formatting branch, thanks!

@liniiiiii liniiiiii merged commit e9fae26 into main Oct 3, 2024
@liniiiiii liniiiiii deleted the earth_data_for_maps branch October 3, 2024 08:20
@i-be-snek
Copy link
Collaborator

@liniiiiii

For the future, always include ALL THE CHANGES FOR ONE FULL FEATURE per PR/branch rather than splitting them over several ones. The README formatting branch (#148) is only meant for superficial formatting of files and improving the language in README for features that already exist.

When we include all files and changes for a certain task in a single branch, we can easily revert the changes all at once using only one commit SHA in the future should things go wrong for any reason. It's also impressively helpful in situations like the other day when I needed to fix the main branch history -- it was helpful that everything was named properly, contained files from only a single feature, and so on.

@liniiiiii
Copy link
Collaborator Author

@liniiiiii

For the future, always include ALL THE CHANGES FOR ONE FULL FEATURE per PR/branch rather than splitting them over several ones. The README formatting branch (#148) is only meant for superficial formatting of files and improving the language in README for features that already exist.

When we include all files and changes for a certain task in a single branch, we can easily revert the changes all at once using only one commit SHA in the future should things go wrong for any reason. It's also impressively helpful in situations like the other day when I needed to fix the main branch history -- it was helpful that everything was named properly, contained files from only a single feature, and so on.

I see the point, big thanks for the suggestions, I will follow them in the coming branches!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants