Skip to content

seed database, render one photo#1

Open
slattouf95 wants to merge 1 commit intomasterfrom
render1photo
Open

seed database, render one photo#1
slattouf95 wants to merge 1 commit intomasterfrom
render1photo

Conversation

@slattouf95
Copy link
Collaborator

No description provided.

@slattouf95
Copy link
Collaborator Author

@DavidPatterson-Cole @bcronin2 @jlukenoff Hey guys, I have been on the slow side the past 2 days will try my best to be better when it comes to code reviews

@jlukenoff
Copy link

@slattouf95 looks good! only a couple of notes:

-in your public/index.html file it looks like you're importing react/react-dom from a cdn using a script tag, this may not be necessary since you're using webpack

-other thing is there seem to be a lot of awscli package files that were committed with this commit, not sure if you need them since your using aws and i'm not but wanted to bring it to you attention regardless

cheers!d

@slattouf95
Copy link
Collaborator Author

@jlukenoff noted! Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants