Open
Conversation
Collaborator
Author
|
@DavidPatterson-Cole @bcronin2 @jlukenoff Hey guys, I have been on the slow side the past 2 days will try my best to be better when it comes to code reviews |
|
@slattouf95 looks good! only a couple of notes: -in your public/index.html file it looks like you're importing react/react-dom from a cdn using a script tag, this may not be necessary since you're using webpack -other thing is there seem to be a lot of awscli package files that were committed with this commit, not sure if you need them since your using aws and i'm not but wanted to bring it to you attention regardless cheers!d |
Collaborator
Author
|
@jlukenoff noted! Thanks for the feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.