Fixed getTypes for types without argument data#6
Open
Reimajo wants to merge 1 commit intoValdemarOrn:masterfrom
Open
Fixed getTypes for types without argument data#6Reimajo wants to merge 1 commit intoValdemarOrn:masterfrom
Reimajo wants to merge 1 commit intoValdemarOrn:masterfrom
Conversation
When using types without argument data, e.g. Bools, the message end with the type. Since no byte follows, msg.Length is index + 4 in this case and getTypes needs to check i <= msg.Length and not i < msg.Length
|
Hey, I just ran into this same issue. I made this same change locally and it worked. Looks like this might solve #5 , this change should be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using types without argument data, e.g. Bools, the message end with the type. Since no byte follows, msg.Length is index + 4 in this case and getTypes needs to check i <= msg.Length and not i < msg.Length