Skip to content

Conversation

@minecraftbossdj
Copy link

its commit worthy according to brickyboy124

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Thettigerking
Copy link

Thettigerking commented Nov 4, 2025

you beat me by 1 minute:(
If only i knew how to make pull requests before

edit: Hes using mine yay

@blockninja124
Copy link
Contributor

Both PRs kinda do stuff wrong :P
So I'll have to do some changes myself anyway, however tigers PR does change slightly more. This PR seems to comment out everything except registrate? Not sure how thats meant to work...

But then again, both PRs yeeted flywheel lmao. So yeah, I'll be using Tigerkings PR, but with changes. I appreciate the contribution from both of you though, and don't let this awkward situation discourage either of you from contributing in the future :D

@blockninja124
Copy link
Contributor

Actually I think I'll do all the gradle changes myself, its just easier since I know what needs changing.

@minecraftbossdj
Copy link
Author

oh yeah another thing, it seems as if ruby's github token has expired and thats why it might not compile, since it cant grab dProtect, you can easily fix this by replacing it with your own, its in the fabric build.gradle. Thought id let you know!

@blockninja124
Copy link
Contributor

We don't need dprotect anymore, so it's fine. I'm just going to remove it entirely. The token no longer works because we burned it after realising it was exposed in this repo lmao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants