This repository was archived by the owner on Jan 11, 2019. It is now read-only.
Updated Url implementation #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
thanks! I'm not using this project and I thought nobody did. Are you using it as a playground or trying to really use it? |
Author
|
Both... I'm trying to use Rust in some side tasks on my job, I don't need to use it, but I'm "for fun and profit" |
Owner
|
OK, thanks! I am traveling at the moment but will look at this PR when I get back |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm really new to rust, so please, be very critique about this PR. I know it's only a few lines but I want to learn and improve my code
What ?
As I started a new project with cargo, when running
cargo installI got lots of errorsHow ?
Removed the Url version constraint and updated the respective methods