Refactor Service to use Lombok and improve encapsulation
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced `@FieldDefaults` for consistent field access levels and made `repositoryMap` private and final. Added a getter method for `repositoryMap` to improve encapsulation and adhere to OOP principles. This enhances code readability and maintainability.
The VaxCommandRegistry field and its initialization were removed as they are no longer used in the code. This cleanup reduces redundancy and improves the maintainability of the BaseAPI class.
Replaced direct map insertion in `registerCommand` with a call to `registerServerCommand` to centralize command registration logic. Removed the unused `plugin` field for cleanup and improved clarity. These changes simplify the registry and ensure commands are properly tracked and synchronized.
Introduce a new `getMessageList` method to fetch a list of components based on a path and optional tag resolvers. This enhances flexibility for handling multi-line messages in the language system.
Replaced manual session closing with try-with-resources to ensure proper resource management and avoid potential memory leaks. This improves code readability and guarantees session closure even in case of exceptions.
Knerio
suggested changes
Dec 30, 2024
Contributor
Knerio
left a comment
Knerio
left a comment
There was a problem hiding this comment.
The build is also failing, please double check
Extracted common language and resolver initialization logic into a new `initializeLanguageAndResolvers` method. This reduces duplication across methods and improves code maintainability and readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced
@FieldDefaultsfor consistent field access levels and maderepositoryMapprivate and final. Added a getter method forrepositoryMapto improve encapsulation and adhere to OOP principles. This enhances code readability and maintainability.