fix(cloud): improve dark mode readability by updating styles and clas…#208
Merged
DenizAltunkapan merged 2 commits intomainfrom Mar 30, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Cloud Page styling to improve text/element contrast in Dark Mode by replacing hardcoded light-theme Tailwind colors with theme CSS variables, while aiming to preserve Light Mode appearance.
Changes:
- Introduced Cloud-specific theme classes (
cloud-btn,cloud-card,cloud-modal, etc.) backed by CSS variables. - Updated Cloud Page template to use the new theme classes for header, breadcrumbs, table, dropdown, and file editor modal.
- Improved loading indicator color behavior by using
border-current.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| frontend/src/app/pages/cloud/cloud.component.scss | Adds theme-variable-based component styles for containers, buttons, dropdowns, table rows, and modal inputs. |
| frontend/src/app/pages/cloud/cloud.component.html | Replaces hardcoded Tailwind light colors with the new Cloud theme classes across the page and modal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…umb affordance, remove redundant min-h-screen Agent-Logs-Url: https://github.com/Vault-Web/vault-web/sessions/afaef1a3-f34f-4b6e-9aea-d7732ffe104a Co-authored-by: DenizAltunkapan <93663085+DenizAltunkapan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hover:bg-gray-100from dropdown items incloud.component.html!importantfrom dropdown hover incloud.component.scss!importantfrom.cloud-row:hoverincloud.component.scsscursor-pointer/hover:underlineto breadcrumb when!last(moved into.cloud-linkSCSS class)min-h-screenfromcloud.component.html:1