[2.0] support calls with gas paid by other account. #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmato
reviewed
May 23, 2025
src/actions.cpp
Outdated
| balance_table.modify(balance_table.get(ingress_account.value), eosio::same_payer, [&](balance& b){ | ||
| b.balance -= value_with_max_gas; | ||
| }); | ||
| if (rc.gas_payer != 0) { |
Contributor
There was a problem hiding this comment.
Why not deduct value_with_max_gas directly in one step here?
Contributor
Author
There was a problem hiding this comment.
Because only the gas should be paid by the gas_payer, the value should be deducted from the caller's balance.
elmato
reviewed
May 23, 2025
| bool abort_on_failure = false; | ||
| bool enforce_chain_id = true; | ||
| bool allow_non_self_miner = true; | ||
| uint64_t gas_payer = 0; |
Contributor
There was a problem hiding this comment.
why not use std::optional<eosio::name> here?
elmato
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #834
Will target 2.1.