[2.0] print inline evm tx error in hex #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarkinwho
suggested changes
May 29, 2025
src/actions.cpp
Outdated
| errmsg += std::to_string(size); | ||
| errmsg += "]"; | ||
| size_t i = 0; | ||
| for (; i < max_print_size && i < size; ++i ) { |
Contributor
There was a problem hiding this comment.
maybe consider using std::stringstream?
src/actions.cpp
Outdated
| size_t i = 0; | ||
| for (; i < max_print_size && i < size; ++i ) { | ||
| static const char hex_chars[] = "0123456789ABCDEF"; | ||
| errmsg += " "; |
Contributor
There was a problem hiding this comment.
IMO we should not insert the space here. Firstly, we can save some space here. secondly, in most cases, this hex string would be largely a utf string except for the first several bytes, add space between bytes will only cause trouble when one trying to use some online tool to convert the hex string to utf string
yarkinwho
reviewed
May 29, 2025
src/actions.cpp
Outdated
| if (rc.abort_on_failure) { | ||
| if (receipt.success == false) { | ||
| size_t size = (int)call_result.data.length(); | ||
| constexpr size_t max_print_size = 292;/*max printable solidity error msg size=224*/ |
Contributor
There was a problem hiding this comment.
where does the 292 come from?
yarkinwho
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #838
silkworm PR: VaultaFoundation/silkworm#260