Add support for gifting RAM, which is encumbered and cannot be sold or transfered.

[greg7mdp]

Change Description

Resolves #166.

See requirements and technical proposal.

[heifner]

See requirements and technical proposal.

These hackmd docs are not publicly available. Seems like copying their content into the description would be useful.

[greg7mdp]

See requirements and technical proposal.

These hackmd docs are not publicly available. Seems like copying their content into the description would be useful.

I thought Areg made them publicly available. I can access them when not logged into my ENF account.

[greg7mdp]

I think I should change the parameter names for giftram and ungiftram to from and to (instead of gifter and giftee) to match ramtransfer and also because we reuse the ramtransfer return value which uses from and to.
@arhag ?

[greg7mdp]

questions:

1. do I need a require_recipient(to) in ungiftram?
2. in ramtransfer, the require_recipient calls are made at the end of the action while in sellram at the beginning. Does the location make any difference?
3. is there a rule of thumb I can use to tell whether require_recipient is needed or not.

[heifner]

1. do I need a require_recipient(to) in ungiftram?

Seems like we would want that notification and report in the trace.

2. in ramtransfer, the require_recipient calls are made at the end of the action while in sellram at the beginning. Does the location make any difference?

Doesn't make any difference. They run after the action completes. If the action fails then they don't run.

3. is there a rule of thumb I can use to tell whether require_recipient is needed or not.

My understanding is you want require_recipient when you want to provide the recipient the opportunity to reject the action.

[greg7mdp]

My understanding is you want require_recipient when you want to provide the recipient the opportunity to reject the action.

Thanks Kevin, this helps a lot!

[greg7mdp]

In the last commit I updated a comment formatting. I can undo it if this shouldn't be in this PR.