[REF] account: refactor base lines extraction for taxes computation#646
Open
rolandojduartem wants to merge 1 commit intoVauxoo:18.0from
Open
[REF] account: refactor base lines extraction for taxes computation#646rolandojduartem wants to merge 1 commit intoVauxoo:18.0from
rolandojduartem wants to merge 1 commit intoVauxoo:18.0from
Conversation
rolandojduartem
force-pushed
the
18.0-account-inherit_base_amls-rolando
branch
from
9081cc5 to
9dbe4f7
Compare
Author
|
What do you think? @luistorresm @hugho-ad @luisg123v Related to T#96737 |
Author
|
@luistorresm what do you think? |
Collaborator
|
Hello @rolandojduartem Could you avoid to improve the code? I think that it is better only move to the new method, what do you think @hugho-ad ? |
Collaborator
|
@rolandojduartem minimal diff please |
Collaborator
well, changes seems to be ok for me, but I think @luistorresm stands for not chaging the actual logic implemented by Odoo, but only move it to the new metho |
rolandojduartem
force-pushed
the
18.0-account-inherit_base_amls-rolando
branch
from
9dbe4f7 to
3b5f46e
Compare
Author
|
what about now, @luistorresm? |
Collaborator
|
LGTM @rolandojduartem |
Refactored the logic to extract base lines for tax computation in `AccountMove`. Introduced the `_get_base_amls` method to centralize the retrieval of base lines, improving code clarity and maintainability. This change enhances heritability, allowing future modules to override the base lines selection logic in a single place. No functional change is expected, but the code is now easier to extend and maintain, especially for localizations or custom modules that need to alter base line selection for tax calculations.
rolandojduartem
force-pushed
the
18.0-account-inherit_base_amls-rolando
branch
from
3b5f46e to
b33e540
Compare
Collaborator
|
Do you create the PR for Odoo? |
Author
|
@luistorresm I did, odoo#240809 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the logic to extract base lines for tax computation in
AccountMove. Introduced the_get_base_amlsmethod to centralizethe retrieval of base lines, improving code clarity and maintainability.
This change enhances heritability, allowing future modules to override
the base lines selection logic in a single place.
No functional change is expected, but the code is now easier to
extend and maintain, especially for localizations or custom modules
that need to alter base line selection for tax calculations.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr