[Arm64, Apple] Apple arm64 syscall calling convention #7313
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostobriv
force-pushed
the
apple_arm64_syscall_calling_convention
branch
from
ccdc8d1 to
0aee11e
Compare
|
I didn't change anything in mac_kernel platform, as i'm not much familiar with osx kernel stuff, however i have a feeling that syscalls there behave the exact same way, so if i should add cc there lmk |
mostobriv
changed the title
mostobriv
changed the title
bdash
force-pushed
the
apple_arm64_syscall_calling_convention
branch
from
0aee11e to
4c1c871
Compare
|
Thank you very much for the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR addressing #7311. A bit confused why hasn't it been done earlier.
As "macos-syscall" was never registered and used by any of platform types, it is safe to rename it to "apple-syscall" (as it applied to both macos and ios).
Also changed arguments for this cc from X0-X5 to X0-X8 as syscalls on ios/macos can handle up to 9 arguments