Add TableViewBase.h and base class QTableView uses in stringsview, memory map, searches, and tag types #7321
+182
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mory map, searches, and tag types
spoonmilk
added
Component: UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the TableViewBase class for common functionality we'd like in QTableViews in Binary Ninja.
In all tables using TableViewBase,
The reason I chose to safe defaults to a separate path is that many of our TableViews have manually set widths that we don't want to stomp on.
I've also base classed multiple tables (strings view, memory map, searches, tag types) where it is relatively easy. Since some of our tables are a bit more involved (or are actually QTreeViews), some others will require more effort.
Fixes #7248 but unifies behavior.