Add active_pid property to get debugged process ID #873
Conversation
…(python dbg.active_pid)
|
|
There was a problem hiding this comment.
I made two small comments. I will take care of them and then do some functionality tests
One thing that I am not sure about is that the debugger normally uses the DebuggerState object to cache the information about the target, e.g., the registers, threads, etc. And it is updated whenever necessary, e.g., when the target stops. This PR does not follow that pattern. However, I have not yet decided for things like the PID, whether we want it to be cached at all -- because it does not change very often, and it is also not frequently used
| } | ||
|
|
||
|
|
||
| std::uint32_t QueuedAdapter::GetActivePID() |
There was a problem hiding this comment.
This is no need to change anything in queedadapter.cpp, it is a legacy file that is no longer used
|
|
||
| uint32_t DebuggerController::GetActivePID() | ||
| { | ||
| std::lock_guard<std::mutex> lock(m_adapterMutex); |
3 participants
Added
active_pidproperty to get the PID of the process that is currently being debugged. Returns 0 if unavailable or nothing is yet attached.Implementation is added for every adapter, for GDB it's cached at connection time (as then we know the thread id equals the process pid).