feat(SimpleRO): prove commitmentScheme#312
Open
pitmonticone wants to merge 1 commit intoVerified-zkEVM:mainfrom
Open
feat(SimpleRO): prove commitmentScheme#312pitmonticone wants to merge 1 commit intoVerified-zkEVM:mainfrom
commitmentScheme#312pitmonticone wants to merge 1 commit intoVerified-zkEVM:mainfrom
Conversation
This PR adds proofs autoformalised by @Aristotle-Harmonic. Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
9f1c474 to
3aff1e5
Compare
🤖 Gemini PR SummaryThis PR completes the formalization of the Simple Random Oracle (SimpleRO) commitment scheme by implementing its opening protocol. The changes transition the codebase from conceptual placeholders to concrete, verified definitions for both the prover and verifier. Features
Refactoring
Documentation
Analysis of Changes
✅ **Removed:** 1 `sorry`(s)
🎨 **Style Guide Adherence**The following lines violate the ArkLib style guide:
📄 **Per-File Summaries**
Last updated: 2026-02-22 19:11 UTC. |
quangvdao
reviewed
Feb 25, 2026
| receiveChallenge := fun i => i.1.elim0 | ||
| output := fun _ => pure (true, ()) } | ||
| verifier := | ||
| { verify := fun _ _ => pure true } } |
Collaborator
There was a problem hiding this comment.
verify seems wrong here - it should at least check whether the commitment is correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds proofs autoformalised by @Aristotle-Harmonic.
Co-authored-by: Aristotle (Harmonic) aristotle-harmonic@harmonic.fun