fix(issue-214): prove linsolve_none#379
Open
eliasjudin wants to merge 1 commit intoVerified-zkEVM:mainfrom
Open
fix(issue-214): prove linsolve_none#379eliasjudin wants to merge 1 commit intoVerified-zkEVM:mainfrom
eliasjudin wants to merge 1 commit intoVerified-zkEVM:mainfrom
Conversation
🤖 Gemini PR SummaryFormalizes the soundness of the linear system solver's failure case within the Berlekamp-Welch algorithm, resolving issue #214. Mathematical FormalizationProvides a formal proof for the
Implementation Details
Project Context
Resolves: #214 Analysis of Changes
Lean Declarations ✏️ **Removed:** 1 declaration(s)
✅ **Removed:** 2 `sorry`(s)
🎨 **Style Guide Adherence**The following violations of the style guide were identified:
📄 **Per-File Summaries**
Last updated: 2026-03-02 10:48 UTC. |
eliasjudin
added a commit
to eliasjudin/ArkLib
that referenced
this pull request
Mar 2, 2026
Prove `linsolve_none` in `ArkLib/Data/CodingTheory/BerlekampWelch/Sorries.lean` by splitting on existence in `linsolve` and deriving contradiction in the `some` branch. Keep `linsolve_some` unsolved on this branch so PR Verified-zkEVM#379 stays scoped to issue Verified-zkEVM#214. Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
802e32e to
0a05f99
Compare
Prove `linsolve_none` in `ArkLib/Data/CodingTheory/BerlekampWelch/Sorries.lean` by splitting on existence in `linsolve` and deriving contradiction in the `some` branch. Keep `linsolve_some` unsolved on this branch so PR Verified-zkEVM#379 stays scoped to issue Verified-zkEVM#214. Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
0a05f99 to
597bd96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds proofs autoformalised by @Aristotle-Harmonic.
linsolve A b = none → ¬ ∃ x, A.mulVec x = b(linsolve_none).ArkLib/Data/CodingTheory/BerlekampWelch/Sorries.leanlinsolve, contradiction in thesomebranchlinsolve_someis left for PR fix(issue-211): prove linsolve_some #378Resolves #214.
Co-authored-by: Aristotle (Harmonic) aristotle-harmonic@harmonic.fun