feat: completeness of Binary Basefold & ring-switching#383
feat: completeness of Binary Basefold & ring-switching#383chung-thai-nguyen wants to merge 6 commits intomainfrom
Conversation
🤖 Gemini PR SummaryAdvances the formalization of Binary Basefold and Ring-Switching protocols, focusing on perfect completeness and the underlying oracle reduction infrastructure. Mathematical Formalization
Infrastructure and Monadic Tooling
Refactoring
Proof Status and Known Gaps
Statistics
Lean Declarations ✏️ **Removed:** 27 declaration(s)
✏️ **Added:** 532 declaration(s)
✏️ **Affected:** 38 declaration(s) (line number changed)
✅ **Removed:** 13 `sorry`(s)
❌ **Added:** 65 `sorry`(s)
🎨 **Style Guide Adherence**This code review is based on the ArkLib Lean 4 Style Guide. The provided diff contains several violations of the style guide, particularly regarding naming conventions for terms, theorems, and acronyms, as well as formatting rules for operators and empty lines. 1. Spacing and OperatorsThe guide requires: "Put spaces on both sides of
2. Naming Conventions: Terms and FunctionsThe guide requires: "Functions and Terms:
3. Naming Conventions: Theorems and ProofsThe guide requires: "Theorems and Proofs:
4. AcronymsThe guide requires: "Acronyms: Treat as words (
5. Syntax and Formatting
6. Standardized InequalitiesThe guide requires: "In conclusions, use
📄 **Per-File Summaries**
Last updated: 2026-03-06 12:44 UTC. |
9edd9d8 to
6de2e83
Compare
749ed55 to
2b6222f
Compare
Newer version of #270, migrated to latest VCV-io APIs.
[x] Lemma 4.9 & Lemma 4.13 of FRI-Binius (BinaryBasefold/Prelude.lean)
[x] Completeness unfolding tools & snippets - mainly tools for converting the monadic defs into the logical defs (Completeness.lean, ReductionLogic.lean, Simulation.lean, Lemmas.lean) + new cast definition of oracle reduction (OracleReduction/Cast.lean) with completeness/rbrks compatibility
[x] Perfect completeness for Binary Basefold & ring-switching (+ some loose index refactoring to avoid type checking burden on Fin type)
[x] Reintroduce AdditiveNTT.lean with index changes, will be migrated to CompPoly later
[x] Depend on the latest VCV-io OptionT API: Verified-zkEVM/VCV-io@84822d6