Conversation
🤖 Gemini PR SummaryEstablishes a dedicated testing infrastructure under a new Testing Infrastructure
Univariate Polynomials
Multivariate Polynomials
Refactoring
Future Outlook
Analysis of Changes
Lean Declarations
🎨 **Style Guide Adherence**The following violations of the style guide were identified in the provided diff:
📄 **Per-File Summaries**
Last updated: 2026-03-03 15:16 UTC. |
|
@alexanderlhicks @quangvdao I think that it is likely a good idea to have a test suite to complement the formal proofs of correctness since this is a computable library. Reasons for including a test suite:
|
|
I think it would be great! We will be starting working on the implementation of the ntt this week, and we were thinking we should be able to do basic tests before starting the correctness proof. I believe we can integrate those tests to this test suite. |
|
Going to merge for the sake of having it here and getting regression tests out of Raw.lean. The main thing with using it is probably:
|
dhsorens
left a comment
There was a problem hiding this comment.
This pull request only removes regression tests from Raw.lean and leaves the rest of the extant code in place with no breaking changes introduced. Merging
Any computable library should have a test suite! Especially with Phase 2 nearly under way. This pull request starts that with some basic tests, including ones recently added to Univariate/Raw.lean. This is a very basic test suite, we'll want to build it out especially as we start making algorithms more efficient. Some clear TODOs include including stronger tests for functions, especially when the formal spec may or may not fully cover it. We should also consider build times and choose tests carefully, but for now this is the basic infrastructure.